Skip to content

Permit WP-CLI to be built as a phar when dependency of another project #3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schlessera merged 2 commits into from
Mar 24, 2017
Merged

Permit WP-CLI to be built as a phar when dependency of another project #3923

schlessera merged 2 commits into from
Mar 24, 2017

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Mar 23, 2017

Used in wp-cli/package-command#2

To verify in the package-command project:

git clone git@github.com:wp-cli/package-command.git
cd package-command
git checkout 1-phar-access
composer install
behat features/package-install.feature
cd vendor/wp-cli/wp-cli
git checkout phar-build-subproject
cd -

Here's the current test that fails: https://travis-ci.org/wp-cli/package-command/jobs/214240701

@danielbachhuber danielbachhuber added this to the 1.2.0 milestone Mar 23, 2017
@schlessera schlessera merged commit e0ad2a5 into master Mar 24, 2017
@schlessera schlessera deleted the phar-build-subproject branch March 24, 2017 13:19
@gitlost gitlost mentioned this pull request Jun 26, 2017
Merged
@gitlost gitlost mentioned this pull request Aug 1, 2017
Merged
@gitlost gitlost mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

scope:bootstrap scope:distribution Related to distribution

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@danielbachhuber @schlessera