Skip to content

Permit dev-master for required WP-CLI packages #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielbachhuber merged 3 commits into from
Mar 22, 2017
Merged

Permit dev-master for required WP-CLI packages #3921

danielbachhuber merged 3 commits into from
Mar 22, 2017

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Mar 22, 2017

Hopefully this fixes:

 Problem 1
    - Installation request for wp-cli/package-command dev-2a4ac19b859ac77c92e60efc972e539c6b834fb1 -> satisfiable by wp-cli/package-command[dev-2a4ac19b859ac77c92e60efc972e539c6b834fb1].
    - wp-cli/wp-cli dev-master requires wp-cli/package-command ^1.0 -> satisfiable by wp-cli/package-command[v1.0.0].
    - Can only install one of: wp-cli/package-command[v1.0.0, dev-2a4ac19b859ac77c92e60efc972e539c6b834fb1].
    - Installation request for wp-cli/wp-cli dev-master -> satisfiable by wp-cli/wp-cli[dev-master].

From https://travis-ci.org/wp-cli/package-command/jobs/213828196
Related wp-cli/package-command#2

@danielbachhuber danielbachhuber added this to the 1.2.0 milestone Mar 22, 2017
@danielbachhuber
Copy link
Member Author

danielbachhuber commented Mar 22, 2017

@schlessera Does this seem sensible to you?

@schlessera
Copy link
Member

schlessera commented Mar 22, 2017

No, this should be handled with the following set of Composer options:

	"minimum-stability": "dev",
	"prefer-stable": true,

@danielbachhuber
Copy link
Member Author

danielbachhuber commented Mar 22, 2017

No, this should be handled with the following set of Composer options

Like 46995f2 ?

@schlessera
Copy link
Member

schlessera commented Mar 22, 2017

Yes. That should have the same effect, using the latest matching stable as far as possible, and falling back to dev-master if no stable fits the requirements.

@danielbachhuber danielbachhuber merged commit afe561b into master Mar 22, 2017
@danielbachhuber danielbachhuber deleted the permit-dev-master branch March 22, 2017 17:49
@danielbachhuber danielbachhuber mentioned this pull request Mar 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

scope:framework

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@danielbachhuber @schlessera