Conversation
|
@nacin how do you feel about |
|
wp_download_language_pack() only works with core. You should probably use Language_Pack_Upgrader directly anyway. I can help with this. get_available_languages() is old-school API that is only for core languages. The newer, better version of this is wp_get_installed_translations(), which accepts a $type argument. There is no uninstall API for language packs at the moment. I guess there could be. We don't actually (yet) remove them when deleting a theme or plugin, though that will probably come in 4.1 (cc @ocean90). Simply removing the file is sufficient. Translations can be updated, as well. It's not as obvious because this happens at the same time as core, plugin, and theme updates. A translation can be updated (say, to fix a typo) and still be the same version (of the core/plugin/theme) — the difference is in the PO file creation dates, which are compared API-side. It's actually all super complicated, the more I think about it. No wonder it took this long to do... |
|
Chatted with @johnbillion today and we came to a couple of decisions:
|
|
Hi All, Not sure if this issue #1374 (posted by me) resulted in this conversation getting lively, nevertheless. I run a dutch hosting company and manage a decent amount of websites. Beyond a staging area I have enough websites where I can inventory behaviour of the above command. Should any help be needed, feel free to get in touch. Cudo's on the work!! Kind regards, Gerard. |
Thanks for the offer! Mind installing the master branch of WP-CLI and giving it some testing? We're hoping to release in the next day or so. |
|
Sure, I assume the nightly phar installed from "https://raw.github.com/wp-cli/builds/gh-pages/phar/wp-cli-nightly.phar" is the Master branch you're referring to or is that a distinct deploy branch? |
|
That build is out of date (and doesn't include |
|
What about translation updates? Left for later? |
|
Typically I think you should add those. However, if I'm correct, Wordpress updates these when themes or plugins are installed. I see the "updating languages" as a new phenomenon in my terminals more often these days ... So since more frequently updated less of a priority for now I think. Moreover, if you want to control updates, then you should also be able to check whether updates are available. And this sounds like handling language update as complete as plugin or theme updates. Ofc, correct me if I'm wrong :) |
|
@danielbachhuber thanx for the info |
See #714, #1357, #1381