Skip to content

Resolve duplicate copies of RecursiveDataStructureTraverser #5837

Closed

Description

@danielbachhuber

We have two copies of RecursiveDataStructureTraverser, one in https://github.com/wp-cli/entity-command/ and one in https://github.com/wp-cli/cache-command/.

Ideally, we'd just have one copy of the class. It could live in this repository, or it could live as a standalone package.

From wp-cli/cache-command#89

Done is:

  • We only have one copy of the class, and it's referenced by each repository.

Activity

  1. thelovekesh commented on Nov 10, 2023

    @thelovekesh
    Member

    @danielbachhuber Since this will also need to be updated in wp-cli/entity-command, I have opened an issue for that wp-cli/entity-command#435

  2. thelovekesh commented on Nov 13, 2023

    @thelovekesh
    Member

    As discussed on WP CLI hack day, these changes will be part of a new package - https://github.com/wp-cli/wp-recursive-traverser

  3. schlessera commented on Nov 14, 2023

    @schlessera
    Member

    After a follow-up discussion in #5866, we decided to include it in the WP-CLI framework instead as initially planned.

  4. thelovekesh commented on Feb 10, 2024

    @thelovekesh
    Member

    @danielbachhuber @schlessera Since this has landed in the WP CLI 2.10.0 release, I think we can close it as completed.

  5. danielbachhuber commented on Feb 11, 2024

    @danielbachhuber
    MemberAuthor

    Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions