Repository navigation
Get tests passing again in all repositories #5810
Description
We have a lot of automated test failures right now. Let's get them passing again!
Done is:
- Automated tests are passing in all repositories.
{{ message }}
We have a lot of automated test failures right now. Let's get them passing again!
Done is:
Activity
swissspidy commentedon Jul 12, 2023
Now that wp-cli/.github#61 has been merged, let's re-run some tests to see if they still fail now.
Some are now already passing again, so that's great 🎉
Note: Some packages (e.g. widget-command, package-command, maintenance-mode-command, language-command, embed-command) haven't run tests in a while, so we need to push some changes to trigger a run
➡️ #58673 is a common issue across many packages. It will be resolved hopefully before RC. No action needed from our side!
wp-cli/scaffold-command
Still some failures:
Scenario: Install WordPress from trunk(in general)Scenario: Install WordPress from trunk(on PHP 5.6 + WP latest)@require-php-7.0tagwp-cli/profile-command
Scenario: Error when SAVEQUERIES is defined to falsewp-cli/db-command
Scenario: Clean up a WordPress install without dropping its database entirely but tables with prefixwojsmol commentedon Jul 12, 2023
For this re-enabiling a testing workflow will be enough.
swissspidy commentedon Jul 12, 2023
We tested it earlier and I was not able to re-run tests after re-enabling the workflows because the runs were too old (more than 90 days). See for example https://github.com/wp-cli/maintenance-mode-command/actions/workflows/testing.yml
wojsmol commentedon Jul 12, 2023
@swissspidy After re-enabling https://github.com/wp-cli/maintenance-mode-command/blob/5d51793771c3d927ef9c501b527ea42d30c9838c/.github/workflows/testing.yml#L9-L10 should work Manual run is not allowed for testing workflow.
To at least receive notification when a repo is stale we can use https://github.blog/2023-06-05-announcing-the-stale-repos-action/ in a
wp-cli/dashbordreposwissspidy commentedon Jul 12, 2023
@wojsmol That's not what I meant, I was referring to this button which is missing in those cases:
But yeah I'll just wait for the next test to be triggered.
swissspidy commentedon Jul 12, 2023
wp-cli/core-command(run)001 Example: | trunk | When I run wp core update --version=trunkExample: | nightly | When I run wp core update --version=nightly003 Scenario: Installing latest nightly build should skip cacheThese should all get
@require-php-7.0wp-cli/automated-testsI think that's it. We can go through all of them again once that bug in core is fixed.
swissspidy commentedon Jul 12, 2023
wp-cli/search-replace-command(run)001 Scenario: Run on all tables matching string with wildcardswissspidy commentedon Jul 13, 2023
This fix in trunk should resolve most failures now: https://core.trac.wordpress.org/changeset/56226
danielbachhuber commentedon Jul 13, 2023
Tagged some releases and submitted an update to the bundle wp-cli/wp-cli-bundle#559
swissspidy commentedon Jul 13, 2023
So far it's looking really good!
search-replace-commandstill needs looking into: https://github.com/wp-cli/search-replace-command/actions/runs/5538237598/jobs/10118012114In the
automated-testsrepoembed-commandis now failing when trying to dowp embed provider match https://asciinema.org/a/140798. Tests passed in theembed-commandrepo itself though yesterday. But I don't know why.asciinema.org is not an allowlisted oEmbed provider in WordPress and does not oEmbed meta tags to its web pages. Maybe they just removed that recently? In that case we would need to update tests to use different URLs.
media-command: the tests were disabled, I just re-enabled the workflow.This test appears to be failing as it tries to upgrade to trunk on PHP 5.6:
https://github.com/wp-cli/media-command/blob/0334b288f123861714029c843d1ea9410ebb7f27/features/media-regenerate.feature#L1214-L1226
Any ideas?
danielbachhuber commentedon Jul 13, 2023
Seems to be some collision with a new core option in trunk. I tweaked the test with wp-cli/search-replace-command#185
Yeah, let's swap with a different provider.
We can skip the test because it's only applicable to PHP 5.6: wp-cli/media-command#179
swissspidy commentedon Jul 13, 2023
Fix for the embed command:
swissspidy commentedon Jul 13, 2023
The dashboard is all green now! 🎉
danielbachhuber commentedon Jul 13, 2023
Thanks for your work on this, @swissspidy ! 🙌