Skip to content

Variables need quoting in ci/prepare.sh #4838

New issue
New issue
Closed
Closed
Variables need quoting in ci/prepare.sh#4838
Labels
good-first-issueGood for newcomersscope:distributionRelated to distribution
Milestone
2.0.0
@schlessera

Description

@schlessera
schlessera
opened on Jul 11, 2018

Additional quoting is needed in ci/prepare.sh to make sure we don't hit random issues with globbing or word splitting.

$(phpenv version-name):

wp-cli/ci/prepare.sh

Line 10 in 3aac73b

if [ -f ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/xdebug.ini ]; then

$CLI_VERSION:

wp-cli/ci/prepare.sh

Line 29 in 3aac73b

echo $CLI_VERSION > VERSION

$WP_CLI_BIN_DIR:

wp-cli/ci/prepare.sh

Line 31 in 3aac73b

mkdir -p $WP_CLI_BIN_DIR

$CLI_VERSION:

wp-cli/ci/prepare.sh

Line 32 in 3aac73b

php -dphar.readonly=0 utils/make-phar.php wp-cli.phar --quiet --version=$CLI_VERSION

$WP_CLI_BIN_DIR/wp:

wp-cli/ci/prepare.sh

Line 33 in 3aac73b

mv wp-cli.phar $WP_CLI_BIN_DIR/wp

$WP_CLI_BIN_DIR/wp:

wp-cli/ci/prepare.sh

Line 34 in 3aac73b

chmod +x $WP_CLI_BIN_DIR/wp

$CLI_VERSION:

wp-cli/ci/prepare.sh

Line 37 in 3aac73b

echo $CLI_VERSION > PHAR_BUILD_VERSION

See https://github.com/koalaman/shellcheck/wiki/SC2086

Metadata

Metadata

Assignees

No one assigned

    Labels

    good-first-issueGood for newcomersscope:distributionRelated to distribution

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions