Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wp-cli/wp-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: wp-cli/wp-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix/gracefully-handle-missing-extension
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 2 files changed
  • 2 contributors

Commits on May 8, 2024

  1. Prevent missing file extensions from throwing errors

    Some file URL do not include the common .zip extension and therefore are missing their extension when reaching the `import` method of `FileCache`.
    
    This issue is commonly seen with Premium plugins which use a custom URL to provide access to a keyed download file.
    
    Running `wp plugin update <name of premium plugin>` was throwing a "Warning: copy(-<version>.): Failed to open stream: Permission denied". 
    
    Instead of assuming the extension is valid nor trying to guess the extension is `.zip` simply bypass the storing of cache when the extension is not available.
    lipemat authored May 8, 2024
    Configuration menu
    Copy the full SHA
    9a262f9 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    1b48404 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    132222f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    297548a View commit details
    Browse the repository at this point in the history
Loading