Fix debug message to show clearer retry numbers and update PHPDoc

Copilot · swissspidy · Copilot · commit e9cc891f98cc · 2025-12-10T09:11:33.000Z
Co-authored-by: swissspidy &lt;841956+swissspidy@users.noreply.github.com&gt;
diff --git a/php/utils.php b/php/utils.php
@@ -969,7 +969,7 @@ function http_request( $method, $url, $data = null, $headers = [], $options = []
 
 				// Store exception and retry.
 				$last_exception = $exception;
-				WP_CLI::debug( sprintf( 'Retrying HTTP request to %s (attempt %d/%d) after transient error: %s', $url, $attempt, $max_retries + 1, $exception->getMessage() ), 'http' );
+				WP_CLI::debug( sprintf( 'Retrying HTTP request to %s (retry %d/%d) after transient error: %s', $url, $attempt - 1, $max_retries, $exception->getMessage() ), 'http' );
 				sleep( $retry_after_delay );
 				$retry_after_delay = min( $retry_after_delay * 2, 10 ); // Exponential backoff, max 10 seconds.
 				continue;
diff --git a/tests/UtilsTest.php b/tests/UtilsTest.php
@@ -1145,8 +1145,8 @@ public function testIsTransientHttpError(): void {
 	/**
 	 * Create a mock Requests exception.
 	 *
-	 * @param string      $type        Exception type.
-	 * @param \CurlHandle $curl_handle Curl handle.
+	 * @param string                  $type        Exception type.
+	 * @param \CurlHandle|resource    $curl_handle Curl handle (resource in PHP < 8.0, object in PHP >= 8.0).
 	 * @return \WpOrg\Requests\Exception Mock exception.
 	 */
 	private function createMockRequestsException( $type, $curl_handle ) {
