Correct completion case when ends in =

Roy-Orbison · Roy-Orbison · commit c9484bea4984 · 2024-03-06T16:01:56.000+10:30
diff --git a/features/cli-bash-completion.feature b/features/cli-bash-completion.feature
@@ -101,6 +101,12 @@ Feature: `wp cli completions` tasks
       """
 
     When I run `wp cli completions --line='wp config create --dbname=' --point=100`
+    Then STDOUT should not contain:
+      """
+      --dbname=
+      """
+
+    When I run `wp cli completions --line='wp config create --dbname' --point=100`
     Then STDOUT should contain:
       """
       --dbname=
diff --git a/php/WP_CLI/Completions.php b/php/WP_CLI/Completions.php
@@ -120,8 +120,8 @@ private function get_command( $words ) {
 		end( $words );
 		$last_arg_i = key( $words );
 		foreach ( $words as $i => $arg ) {
-			if ( preg_match( '|^--([^=]+)=?|', $arg, $matches ) ) {
-				if ( $i === $last_arg_i ) {
+			if ( preg_match( '|^--([^=]+)(=?)|', $arg, $matches ) ) {
+				if ( $i === $last_arg_i && '' === $matches[2] ) {
 					continue;
 				}
 				$assoc_args[ $matches[1] ] = true;
