Add missing required arguments when using --prompt

2ndkauboy · 2ndkauboy · commit 7d10ddce9cb9 · 2023-11-10T13:13:06.000+01:00
When using the `--prompt` argument on a command, the executed command
gets logged, showing the command and arguments the prompt had collected.

This logged command, however, lacks all required `$args` and only lists
the `$assoc_args` (that are not empty).

This patch will add the required arguments as well.
diff --git a/features/prompt.feature b/features/prompt.feature
@@ -204,3 +204,25 @@ Feature: Prompt user for input
       """
       "Hello world!",hello-world,publish
       """
+
+  Scenario: Prompt should show positional arguments
+    Given a WP installation
+    And a value-file file:
+      """
+      category
+      General
+      general
+
+
+
+      """
+
+    When I run `wp term create --prompt < value-file`
+    Then STDOUT should contain:
+      """
+      wp term create 'category' 'General' --slug='general'
+      """
+    And STDOUT should contain:
+      """
+      Created category
+      """
diff --git a/php/WP_CLI/Dispatcher/Subcommand.php b/php/WP_CLI/Dispatcher/Subcommand.php
@@ -480,7 +480,7 @@ public function invoke( $args, $assoc_args, $extra_args ) {
 				sprintf(
 					'wp %s %s',
 					$cmd,
-					ltrim( Utils\assoc_args_to_str( $actual_args ), ' ' )
+					ltrim( implode( ' ', [ Utils\args_to_str( $args ), Utils\assoc_args_to_str( $actual_args ) ] ), ' ' )
 				)
 			);
 		}

Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,7 @@ public function invoke( $args, $assoc_args, $extra_args ) {`
`480`	`480`	`sprintf(`
`481`	`481`	`'wp %s %s',`
`482`	`482`	`$cmd,`
`483`		`- ltrim( Utils\assoc_args_to_str( $actual_args ), ' ' )`
	`483`	`+ ltrim( implode( ' ', [ Utils\args_to_str( $args ), Utils\assoc_args_to_str( $actual_args ) ] ), ' ' )`
`484`	`484`	`)`
`485`	`485`	`);`
`486`	`486`	`}`