Merge pull request #6088 from wp-cli/fix/esc_like-for-sqlite

schlessera · web-flow · commit 0175f1311120 · 2025-05-05T23:54:56.000+02:00
diff --git a/php/utils.php b/php/utils.php
@@ -1674,6 +1674,15 @@ function _proc_open_compat_win_env( $cmd, &$env ) {
  *                or real_escape next.
  */
 function esc_like( $text ) {
+	global $wpdb;
+
+	// Check if the esc_like() method exists on the global $wpdb object.
+	// We need to do this because to ensure compatibilty layers like the
+	// SQLite integration plugin still work.
+	if ( null !== $wpdb && method_exists( $wpdb, 'esc_like' ) ) {
+		return $wpdb->esc_like( $text );
+	}
+
 	return addcslashes( $text, '_%\\' );
 }
 
diff --git a/tests/UtilsTest.php b/tests/UtilsTest.php
@@ -777,28 +777,52 @@ public static function dataProcOpenCompatWinEnv() {
 		];
 	}
 
+	public static function dataEscLike() {
+		return [
+			[ 'howdy%', 'howdy\\%' ],
+			[ 'howdy_', 'howdy\\_' ],
+			[ 'howdy\\', 'howdy\\\\' ],
+			[ 'howdy\\howdy%howdy_', 'howdy\\\\howdy\\%howdy\\_' ],
+			[ 'howdy\'"[[]*#[^howdy]!+)(*&$#@!~|}{=--`/.,<>?', 'howdy\'"[[]*#[^howdy]!+)(*&$#@!~|}{=--`/.,<>?' ],
+		];
+	}
+
 	/**
-	 * Copied from core "tests/phpunit/tests/db.php" (adapted to not use `$wpdb`).
+	 * @dataProvider dataEscLike
 	 */
-	public function test_esc_like() {
-		$inputs   = [
-			'howdy%', // Single Percent.
-			'howdy_', // Single Underscore.
-			'howdy\\', // Single slash.
-			'howdy\\howdy%howdy_', // The works.
-			'howdy\'"[[]*#[^howdy]!+)(*&$#@!~|}{=--`/.,<>?', // Plain text.
-		];
-		$expected = [
-			'howdy\\%',
-			'howdy\\_',
-			'howdy\\\\',
-			'howdy\\\\howdy\\%howdy\\_',
-			'howdy\'"[[]*#[^howdy]!+)(*&$#@!~|}{=--`/.,<>?',
-		];
+	public function test_esc_like( $input, $expected ) {
+		$this->assertEquals( $expected, Utils\esc_like( $input ) );
+	}
 
-		foreach ( $inputs as $key => $input ) {
-			$this->assertEquals( $expected[ $key ], Utils\esc_like( $input ) );
+	/**
+	 * @dataProvider dataEscLike
+	 */
+	public function test_esc_like_with_wpdb( $input, $expected ) {
+		global $wpdb;
+		$wpdb = $this->getMockBuilder( 'stdClass' );
+
+		// Handle different PHPUnit versions (5.7 for PHP 5.6 vs newer versions)
+		// This can be simplified if we drop support for PHP 5.6.
+		if ( method_exists( $wpdb, 'addMethods' ) ) {
+			$wpdb = $wpdb->addMethods( [ 'esc_like' ] );
+		} else {
+			$wpdb = $wpdb->setMethods( [ 'esc_like' ] );
 		}
+
+		$wpdb = $wpdb->getMock();
+		$wpdb->method( 'esc_like' )
+			->willReturn( addcslashes( $input, '_%\\' ) );
+		$this->assertEquals( $expected, Utils\esc_like( $input ) );
+		$this->assertEquals( $expected, Utils\esc_like( $input ) );
+	}
+
+	/**
+	 * @dataProvider dataEscLike
+	 */
+	public function test_esc_like_with_wpdb_being_null( $input, $expected ) {
+		global $wpdb;
+		$wpdb = null;
+		$this->assertEquals( $expected, Utils\esc_like( $input ) );
 	}
 
 	/**
