Skip to content

Add ids as format for super admin list#60

Merged
swissspidy merged 3 commits intowp-cli:mainfrom
ernilambar:59-ids-format-super-admin-list
Feb 26, 2024
Merged

Add ids as format for super admin list#60
swissspidy merged 3 commits intowp-cli:mainfrom
ernilambar:59-ids-format-super-admin-list

Conversation

@ernilambar
Copy link
Copy Markdown
Member

Fixes #59

@ernilambar ernilambar requested a review from a team as a code owner February 26, 2024 05:37
@swissspidy
Copy link
Copy Markdown
Member

This lists usernames, not user IDs. What am I missing?

@ernilambar
Copy link
Copy Markdown
Member Author

This lists usernames, not user IDs. What am I missing?

Since we treat User ID, user email, or user login as User ID in our user commands, I assumed user_login could also be treated as ID and list as ids. Now I realise displaying actual IDs for ids would make more sense.

@ernilambar
Copy link
Copy Markdown
Member Author

@swissspidy PR is updated. Behat test is not triggered here also.

@swissspidy swissspidy closed this Feb 26, 2024
@swissspidy swissspidy reopened this Feb 26, 2024
@swissspidy swissspidy added this to the 2.0.14 milestone Feb 26, 2024
@swissspidy swissspidy added the command:super-admin-list Related to 'super-admin list' command label Feb 26, 2024
@swissspidy swissspidy merged commit 47a2eb3 into wp-cli:main Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:super-admin-list Related to 'super-admin list' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce ids as format for super-admin list

2 participants