Replace empty namespace autoloader with classmap#62
Merged
danielbachhuber merged 1 commit intowp-cli:mainfrom Feb 17, 2023
mweimerskirch:patch-1
Merged
Replace empty namespace autoloader with classmap#62danielbachhuber merged 1 commit intowp-cli:mainfrom mweimerskirch:patch-1
danielbachhuber merged 1 commit intowp-cli:mainfrom
mweimerskirch:patch-1
Conversation
This fixes the issue described here: wp-cli/wp-cli#5731
danielbachhuber
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue described here: wp-cli/wp-cli#5731
This PR is slightly different compared to the PRs on the other commands, because part of the code is namespaced while another part is not. I still propose to replace the psr-4 autoloader with a classmap for now, until everything is namespaced.