Skip to content

Handle incomplete class (un)serialization gracefully #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 7 commits into from
Apr 21, 2018
+47 −8
Merged

Handle incomplete class (un)serialization gracefully #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba1868f
Add regression test to check behavior with incomplete classes
schlessera Apr 19, 2018
fa686a5
Fix incomplete class serialization behavior
schlessera Apr 19, 2018
fef94e8
Merge branch 'master' into 68-handle-incomplete-class-serialization
schlessera Apr 19, 2018
5245d69
Merge branch 'master' into 68-handle-incomplete-class-serialization
schlessera Apr 20, 2018
556bf85
Only prepare error constants once
schlessera Apr 21, 2018
3c5cb60
Fix conditional logic
schlessera Apr 21, 2018
17c0a88
Another try at fixing the conditional logic
schlessera Apr 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions features/search-replace.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,3 +1032,25 @@ Feature: Do global search/replace
"""
Success: 1 replacement to be made.
"""

# Regression test for https://github.com/wp-cli/search-replace-command/issues/68
Scenario: Incomplete classes are handled gracefully during (un)serialization

Given a WP install
And I run `wp option add cereal_isation 'a:1:{i:0;O:10:"CornFlakes":0:{}}'`

When I try `wp search-replace CornFlakes Smacks`
Then STDERR should contain:
"""
Warning: Skipping an uninitialized class "CornFlakes", replacements might not be complete.
"""
And STDOUT should contain:
"""
Success: Made 0 replacements.
"""

When I run `wp option get cereal_isation`
Then STDOUT should contain:
"""
a:1:{i:0;O:10:"CornFlakes":0:{}}
"""
33 changes: 25 additions & 8 deletions src/WP_CLI/SearchReplacer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace WP_CLI;

use ArrayObject;
use Exception;

class SearchReplacer {
Expand Down Expand Up @@ -89,9 +90,19 @@ private function _run( $data, $serialised, $recursion_level = 0, $visited_data =
}
}

elseif ( $this->recurse_objects && is_object( $data ) ) {
foreach ( $data as $key => $value ) {
$data->$key = $this->_run( $value, false, $recursion_level + 1, $visited_data );
elseif ( $this->recurse_objects && ( is_object( $data ) || $data instanceof \__PHP_Incomplete_Class ) ) {
if ( $data instanceof \__PHP_Incomplete_Class ) {
$array = new ArrayObject( $data );
\WP_CLI::warning(
sprintf(
'Skipping an uninitialized class "%s", replacements might not be complete.',
$array['__PHP_Incomplete_Class_Name']
)
);
} else {
foreach ( $data as $key => $value ) {
$data->$key = $this->_run( $value, false, $recursion_level + 1, $visited_data );
}
}
}

Expand Down Expand Up @@ -155,13 +166,19 @@ public function clear_log_data() {
* @return string Error constant name.
*/
private function preg_error_message( $error ) {
$constants = get_defined_constants( true );
if ( ! array_key_exists( 'pcre', $constants ) ) {
return '<unknown error>';
static $error_names = null;

if ( null === $error_names ) {
$definitions = get_defined_constants( true );
$pcre_constants = array_key_exists( 'pcre', $definitions )
? $definitions['pcre']
: array();
$error_names = array_flip( $pcre_constants );
}

$names = array_flip( $constants['pcre'] );
return isset( $names[ $error ] ) ? $names[ $error ] : '<unknown error>';
return isset( $error_names[ $error ] )
? $error_names[ $error ]
: '<unknown error>';
}
}