Skip to content

Handle incomplete class (un)serialization gracefully#76

Merged
schlessera merged 7 commits intomasterfrom
68-handle-incomplete-class-serialization
Apr 21, 2018
Merged

Handle incomplete class (un)serialization gracefully#76
schlessera merged 7 commits intomasterfrom
68-handle-incomplete-class-serialization

Conversation

@schlessera
Copy link
Copy Markdown
Member

When an unknown class is deserialized, we just throw a warning an avoid making a change, due to the lack of full knowledge of the class.

This also makes sure we don't throw a notice on PHP 7.2, which changed how is_object() deals with _PHP_Incomplete_Class.

Fixes #68

@schlessera schlessera added bug command:search-replace Related to 'search-replace' command labels Apr 19, 2018
@schlessera schlessera added this to the 1.3.0 milestone Apr 19, 2018
@schlessera schlessera requested a review from a team April 19, 2018 11:56
@schlessera schlessera merged commit df1092f into master Apr 21, 2018
@schlessera schlessera deleted the 68-handle-incomplete-class-serialization branch April 21, 2018 01:30
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
…zation

Handle incomplete class (un)serialization gracefully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:search-replace Related to 'search-replace' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant