Merged
Conversation
We leave the content untouched (instead of replacing with `null`) and issue a warning. This is far from ideal, as it can potentially spam the screen full of warnings. However, a better mechanism will require a total refactor of the `SearchReplacer` class. Fixes #65
Member
Author
|
I fail to find a working test to provoke a PCRE error (without just brute-forcing a stack overflow). If anyone has a good idea or some sample code of how to provoke a runtime PCRE check, please let me know so I can add a regression test here. |
Member
|
@schlessera Looks like tests need to be updated for |
Member
Author
|
@danielbachhuber Yes => #78 |
danielbachhuber
approved these changes
Apr 20, 2018
danielbachhuber
added a commit
that referenced
this pull request
Nov 18, 2022
Handle PCRE errors gracefully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We leave the content untouched (instead of replacing with
null) and issue a warning.This is far from ideal, as it can potentially spam the screen full of warnings. However, a better mechanism will require a total refactor of the
SearchReplacerclass.Fixes #65