Skip to content

Improve --regex-limit logic #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miya0001 merged 6 commits into from
Feb 18, 2018
Merged

Improve --regex-limit logic #70

miya0001 merged 6 commits into from
Feb 18, 2018

Conversation

@alpipego
Copy link

@alpipego alpipego commented Feb 17, 2018

@miya0001 please see my #wcbkk changes, I have not yet update the tests; but I'll be glad to continue working on updating them also.

@alpipego alpipego changed the base branch from master to patch-61 February 17, 2018 06:46
@gitlost
Copy link
Contributor

gitlost commented Feb 17, 2018

Thanks for the PR @alpipego but as this is being dealt with already in #62 I think it's best to leave it there. I do like your $match_cnt suggestion though and will note it on the original PR, ta!

@gitlost gitlost closed this Feb 17, 2018
@gitlost gitlost mentioned this pull request Feb 17, 2018
Merged
@gitlost
Copy link
Contributor

gitlost commented Feb 17, 2018

I should add @alpipego that there're loads of other issues around where your contribution would be most welcome...

@alpipego
Copy link
Author

alpipego commented Feb 17, 2018

@gitlost the PR was against patch-61. It incorporates your suggested changes on #62.

This is the result of WordCamp Bangkok Contributer Day where @miya0001 is leading the WPCLI team.

@gitlost
Copy link
Contributor

gitlost commented Feb 17, 2018

Okay so the easiest thing to do is to re-open this PR and close #62 ?

@gitlost gitlost reopened this Feb 17, 2018
@gitlost gitlost added this to the 1.3.0 milestone Feb 17, 2018
@alpipego
Copy link
Author

alpipego commented Feb 17, 2018

I thought merging it with #62 would be easiest, as I have not updated the tests (@miya0001 is going to do that on #62).

Moreover he didn't create the PR from a fork... Otherwise I'd have created the PR against @miya0001's remote (if that does make any sense).

@miya0001
Copy link
Member

miya0001 commented Feb 18, 2018

Thanks @alpipego for your contribution.
I merge this PR into #62 for now.

@miya0001 miya0001 merged commit f542ed4 into wp-cli:patch-61 Feb 18, 2018
@schlessera schlessera modified the milestones: 1.3.0, 1.4.0 Apr 21, 2018
@schlessera schlessera changed the title Patch 61 Improve --regex-limit logic May 29, 2018
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
@miya0001
Merge pull request #70 from alpipego/patch-61
e6a2c23 
Patch 61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

command:search-replace

Projects

None yet

Milestone

1.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@alpipego @gitlost @miya0001 @schlessera