Skip to content

Fix regex invalid delimiter test for PHP 8.2 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 3 commits into from
May 10, 2023
Merged

Fix regex invalid delimiter test for PHP 8.2 #181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbfbaf7
Fix regex invalid delimiter test for PHP 8.2
brandonpayton May 10, 2023
b1671b5
Use single test that works for all tested PHP versions
brandonpayton May 10, 2023
536a527
Restore previous test position and clarify comment
brandonpayton May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions features/search-replace.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,11 +396,16 @@ Feature: Do global search/replace
https://example.com
"""

# NOTE: The preg_match() error message is a substring of the actual message that matches across supported PHP versions.
# In PHP 8.2, the error message changed from
# "preg_match(): Delimiter must not be alphanumeric or backslash."
# to
# "preg_match(): Delimiter must not be alphanumeric, backslash, or NUL"
When I try `wp search-replace 'HTTPS://EXAMPLE.COM' 'https://example.jp/' wp_options --regex --regex-flags=i --regex-delimiter='1'`
Then STDERR should be:
Then STDERR should contain:
"""
Error: The regex '1HTTPS://EXAMPLE.COM1i' fails.
preg_match(): Delimiter must not be alphanumeric or backslash.
preg_match(): Delimiter must not be alphanumeric
"""
And the return code should be 1

Expand Down