Fix regex invalid delimiter test for PHP 8.2 #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
requested changes
May 10, 2023
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Contributor
Author
|
Thanks, @schlessera. I went ahead and applied your patch. It's much better to have a single test like that. I'll move the test back to its original location and maybe tweak the comment a bit. |
schlessera
approved these changes
May 10, 2023
Contributor
Author
|
Strange. Looks like multiple commits from this made it into the main branch. I apologize if I should have rebased this PR first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the invalid-regex-delimiter test is failing under PHP 8.2. This was noticed because of a failing test under another PR(#180).
This PR fixes the test to deal with a changing preg_match() error message in PHP 8.2.
Behat is new to me, so perhaps there is a better way to approach this. But hopefully this is helpful.