Repository navigation
Chunk query that can potentially OOM - #153
Merged
Merged
Conversation
Unbound query has potential to return millions of rows, and it's fairly easy to run into memory problems. e.g. we had a problem with a ~4GB DB that was returning 13 million rows to check for the `meta_value` column. The fix loops through the table fetching 1000 at a time. Added ORDER BY statement, so we can safely iterate through the primary keys. Using ASC ordering, so the new items come last, in case something gets added while it's running.
Contributor
Author
|
Review with |
Fix variable reuse for $wpdb->update()
aidvu
force-pushed
the
update/chunk-php-handle-col
branch
from
December 25, 2020 16:13
23fe462 to
bba9be5
Compare
schlessera
approved these changes
Jan 14, 2021
Member
|
Thanks for the PR, @aidvu ! |
Contributor
Author
|
Glad I could help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbound query has potential to return millions of
rows, and it's fairly easy to run into memory problems.
e.g. we had a problem with a ~4GB DB that was returning
13 million rows to check for the
meta_valuecolumn.The fix loops through the table fetching 1000 at a time.
Added ORDER BY statement, so we can safely iterate through
the primary keys.
Using ASC ordering, so the new items come last,
in case something gets added while it's running.