-
Notifications
You must be signed in to change notification settings - Fork 44
Comparing changes
Open a pull request
base repository: wp-cli/search-replace-command
base: main
head repository: wp-cli/search-replace-command
compare: copilot/add-progress-bar-indicator
- 15 commits
- 2 files changed
- 3 contributors
Commits on Nov 10, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 6b308fd - Browse repository at this point
Copy the full SHA 6b308fdView commit details -
Add progress bar support to search-replace command
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 41bbda5 - Browse repository at this point
Copy the full SHA 41bbda5View commit details -
Add Behat tests for progress bar functionality
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for cd31f29 - Browse repository at this point
Copy the full SHA cd31f29View commit details -
Remove unused progress_bar property
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 61e02c0 - Browse repository at this point
Copy the full SHA 61e02c0View commit details -
Refactor progress tick to reduce code duplication
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 77534f5 - Browse repository at this point
Copy the full SHA 77534f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59217ca - Browse repository at this point
Copy the full SHA 59217caView commit details -
Revert to early continue pattern and fix progress tick to count by batch
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 681d4c0 - Browse repository at this point
Copy the full SHA 681d4c0View commit details
Commits on Nov 13, 2025
-
Suppress progress bar when logging is enabled
Fixes logging test by suppressing progress bar whenever logging is enabled (not just when logging to STDOUT), as the progress bar output can interfere with clean log output. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1f1bb20 - Browse repository at this point
Copy the full SHA 1f1bb20View commit details -
Update test to include search string in generated post content
Modified the "Progress bar shows when not in verbose mode" test to generate posts with content containing http://example.com. This ensures the progress bar has matching rows to process and display when using the --precise flag. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8d65105 - Browse repository at this point
Copy the full SHA 8d65105View commit details
Commits on Nov 14, 2025
-
Fix test by explicitly setting option with search string
Changed test to use `wp option set` to explicitly create an option containing http://example.com, rather than relying on post generation with --post_content parameter. This ensures the test data has a guaranteed match in wp_options table that will be found by --precise mode. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b5da516 - Browse repository at this point
Copy the full SHA b5da516View commit details -
Fix test to check STDERR for progress bar output
Progress bars in WP-CLI output to STDERR, not STDOUT. Updated tests to check STDERR for "Updating" message from progress bar. This fixes the test that was failing because it was checking the wrong output stream. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 46ba4ed - Browse repository at this point
Copy the full SHA 46ba4edView commit details -
Add WP_CLI::log message before progress bar to show processing status
Added WP_CLI::log() call to output "Updating table.column (X rows)" message before creating progress bar. This ensures users see feedback even if the progress bar doesn't display properly, and provides clear indication of what's being processed. Also reverted test back to checking STDOUT as requested. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3e0e5a0 - Browse repository at this point
Copy the full SHA 3e0e5a0View commit details -
Fix progress bar sprintf format strings
Fixed sprintf format strings for make_progress_bar() calls. Changed from 'Progress' (which ignored table/col parameters) to 'Processing table.column' for regular processing and 'Processing table' for exports. This ensures the progress bar displays with meaningful labels. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3efdf0a - Browse repository at this point
Copy the full SHA 3efdf0aView commit details -
Move progress bar initialization into while loop
Moved progress bar setup from before the while loop to inside the loop on first iteration. This ensures the progress bar is created when rows are actually fetched, even if the initial COUNT query returns 0. Addresses issue where COUNT might return 0 but the while loop still fetches rows to process. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0d531c9 - Browse repository at this point
Copy the full SHA 0d531c9View commit details
Commits on Jan 20, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 077285b - Browse repository at this point
Copy the full SHA 077285bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...copilot/add-progress-bar-indicator