Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
There was a problem hiding this comment.
Code Review
This pull request replaces wget with curl for downloading PHPUnit across multiple test scenarios in features/install-wp-tests.feature. Reviewers suggested further enhancing Windows compatibility by removing the chmod command and executing PHPUnit via php instead. There is also a recommendation to refactor the repeated setup logic into a custom Behat step to adhere to DRY principles.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Updates the Behat feature covering install-wp-tests.sh scaffolding to be more Windows-friendly by avoiding executable PHAR assumptions and replacing wget usage.
Changes:
- Replace
wget+chmodwithcurlfor downloading the PHPUnit PHAR. - Invoke the downloaded PHAR via
php phpunit ...instead of executing it directly (./phpunit).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.