Add dependency checks and error handling for svn and download tools#345
Merged
swissspidy merged 3 commits intowp-cli:mainfrom Sep 16, 2024
Merged
Add dependency checks and error handling for svn and download tools#345swissspidy merged 3 commits intowp-cli:mainfrom
swissspidy merged 3 commits intowp-cli:mainfrom
Conversation
Member
|
Some extra hardening sounds good, but why remove all those explanatory comments? |
Contributor
Author
|
Good point, the comments are back. |
swissspidy
approved these changes
Sep 16, 2024
This was referenced Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds checks for missing dependencies (svn, curl, wget) to ensure the script exits gracefully if any are missing. It also improves error handling in the download process to prevent incomplete setups when required tools are unavailable.