fix: all private methods now protected#328
Closed
benjamingrolleau wants to merge 1 commit intowp-cli:mainfrom
Closed
fix: all private methods now protected#328benjamingrolleau wants to merge 1 commit intowp-cli:mainfrom
benjamingrolleau wants to merge 1 commit intowp-cli:mainfrom
Conversation
Member
|
Thanks for the PR, @benjamingrolleau ! If we make these methods Generally, when we do offer utilities, we explicitly indicate them as such, e.g. https://make.wordpress.org/cli/handbook/references/internal-api/ You're welcome to copy whatever code you'd like into your project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue : #327
I've just replaced all private methods by protected methods. We can now extend Scaffold_Command easily.