Add phpcompatibility-wp coding standards to Gitlab template#315
Merged
danielbachhuber merged 1 commit intowp-cli:masterfrom Oct 28, 2022
Merged
Conversation
danielbachhuber
added
the
command:scaffold-plugin-tests
danielbachhuber
approved these changes
Oct 28, 2022
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks again, @Saggre !
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add phpcompatibility-wp coding standards to Gitlab template.
Phpcompatibility-wp is required here:
scaffold-command/templates/.phpcs.xml.dist
Line 23 in 4a14238
Phpcompatibility-wp is already used in Travis template:
scaffold-command/templates/plugin-travis.mustache
Lines 53 to 57 in 4a14238
Phpcompatibility-wp will always include php-compatibility and phpcompatibility-paragonie too:
https://github.com/PHPCompatibility/PHPCompatibilityWP/blob/ed2685318d3af3cd9a1676bea8e3ffc3a972b3b1/composer.json#L26