Repository navigation
Add missing clean-up in templates/install-wp-tests.sh - #283
schlessera merged 4 commits into
Conversation
b49a10e to
12509ac
Compare
| steps: | ||
|
|
||
| - name: Test connect to MySQL | ||
| run: mysql -uroot -proot -h127.0.0.1 -P${{ job.services.mysql.ports[3306] }} -e "SHOW DATABASES" |
There was a problem hiding this comment.
this canary can be removed I guess. I mostly wanted to shed all the potential that the behat and testing side was messing up path or not receiving environment variables.
|
I'd marked the failures as allowed failures. They are all PHP8 being specific about the phpunit this seems to require to pass. |
| fail-fast: false | ||
| matrix: | ||
| php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0'] | ||
| php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4'] |
There was a problem hiding this comment.
Note the removal does not stop PHP8 running, but to remove combinations, and continue using exclude, this seemed necessary.
| - php: '8.0' | ||
| wp: 'latest' | ||
| mysql: '8.0' | ||
| experimental: true |
There was a problem hiding this comment.
This seems to be the only test case missing from the default matrix.
| extensions: mysql, zip | ||
| coverage: none | ||
| tools: composer | ||
| tools: composer, phpunit:5.7.27 |
There was a problem hiding this comment.
specifying this here, I had hoped would mean there would be only one phpunit.
| """ | ||
|
|
||
| When I run `WP_TESTS_DIR=/tmp/behat-wordpress-tests-lib phpunit -c {PLUGIN_DIR}/hello-world/phpunit.xml.dist` | ||
| When I run `WP_TESTS_DIR=/tmp/behat-wordpress-tests-lib /usr/local/bin/phpunit -c {PLUGIN_DIR}/hello-world/phpunit.xml.dist` |
There was a problem hiding this comment.
really this should become part of the PATH that can be specified to the test suite, but this does a for-now fix and it will only ever be for GitHub Actions. 🤷
| """ | ||
|
|
||
| When I run `WP_TESTS_DIR=/tmp/behat-wordpress-tests-lib phpunit -c {PLUGIN_DIR}/hello-world/phpunit.xml.dist` | ||
| When I run `WP_TESTS_DIR=/tmp/behat-wordpress-tests-lib /usr/local/bin/phpunit -c {PLUGIN_DIR}/hello-world/phpunit.xml.dist` |
There was a problem hiding this comment.
12509ac to
5d2be5b
Compare
5d2be5b to
f48f92e
Compare
|
I've rebased this PR and reverted the changes to the GHA testing setup, so that I can merge the fixes to the |
schlessera
changed the title
templates/install-wp-tests.sh
schlessera
added
bug
command:scaffold-plugin-tests
|
Thanks for all the work, @Lewiscowles1986 ! |
|
Thanks @schlessera it wasn't credit I was after, but thanks. |
@schlessera this should fix the branch you posted in WordPress Slack, pending merge of wp-cli/wp-cli-tests#115
For initial run I have included that here. I will then remove it once those works are merged and it should stay green.
I Tidied up the commit log, as this was originally a total experiment conducted mostly using web interface.