Skip to content

Fix PHPCS issues for post-types - #276

Merged
schlessera merged 1 commit into
wp-cli:masterfrom
2ndkauboy:fix/post-type-phpcs-fixes
Nov 1, 2020
Merged

schlessera merged 1 commit into
wp-cli:masterfrom
2ndkauboy:fix/post-type-phpcs-fixes

Conversation

@2ndkauboy

Copy link
Copy Markdown
Contributor

There are some minor PHPCS issue with would generate post types not complying to the WordPress Coding Standards (the "WordPress-Core" ruleset).

@2ndkauboy
2ndkauboy requested a review from a team as a code owner October 1, 2020 21:11
@schlessera schlessera added the command:scaffold-post-type Related to 'scaffold post-type' command label Oct 2, 2020
@schlessera schlessera added this to the 2.0.12 milestone Oct 2, 2020
@schlessera

Copy link
Copy Markdown
Member

The code change looks good. However, there's one test that is failing now that will need to be updated for the new code style:

register_post_type( 'zombie'

@2ndkauboy
2ndkauboy force-pushed the fix/post-type-phpcs-fixes branch from 9ebeafe to 18a15cc Compare October 2, 2020 08:22
@schlessera
schlessera merged commit 9895c22 into wp-cli:master Nov 1, 2020
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:scaffold-post-type Related to 'scaffold post-type' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants