Repository navigation
Make use of $EXTRA connection settings in install_db() - #269
Merged
Merged
Conversation
schlessera
approved these changes
Jul 4, 2020
schlessera
added
bug
command:scaffold-plugin-tests
schlessera
changed the title
$EXTRA connection settings in install_db()
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Fix bug that can't init non default host DB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#249 forget to add $EXTRA parameters when check existing database.
Therefore, when we use install-wp-tests.sh to non default host DB like other Docker container,
we got error:
ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)