Skip to content

Include --ignore-externals when running svn co - #243

Merged
schlessera merged 2 commits into
masterfrom
install-wp-tests-ignore-externals
Nov 25, 2019
Merged

schlessera merged 2 commits into
masterfrom
install-wp-tests-ignore-externals

Conversation

@danielbachhuber

Copy link
Copy Markdown
Member

The SVN externals aren't necessary in this context because we only need the test suite data

The SVN externals aren't necessary in this context because we only need the test suite data
@danielbachhuber danielbachhuber added command:scaffold-plugin-tests Related to 'scaffold plugin-tests' command command:scaffold-theme-tests Related to 'scaffold theme-tests' command labels Nov 22, 2019
@danielbachhuber danielbachhuber added this to the 2.0.8 milestone Nov 22, 2019
@danielbachhuber
danielbachhuber requested a review from a team as a code owner November 22, 2019 22:00
thomasplevy referenced this pull request in gocodebox/lifterlms-tests Nov 22, 2019
@esquinas

Copy link
Copy Markdown

Did you tried adding --ignore-externals just to the second svn co line and see if travis-ci passes?

@danielbachhuber

Copy link
Copy Markdown
Member Author

Did you tried adding --ignore-externals just to the second svn co line and see if travis-ci passes?

I didn't, no.

@schlessera

Copy link
Copy Markdown
Member

Test failures seem to be another SSL issue with the Travis build. I'll look into it.

@schlessera

Copy link
Copy Markdown
Member

@schlessera

Copy link
Copy Markdown
Member

Thanks for the PR, @danielbachhuber!

If you merge latest master, the tests should pass now.

@danielbachhuber

Copy link
Copy Markdown
Member Author

@schlessera Updated!

@schlessera
schlessera merged commit 4814acb into master Nov 25, 2019
@schlessera
schlessera deleted the install-wp-tests-ignore-externals branch November 25, 2019 13:26
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Include `--ignore-externals` when running svn co
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:scaffold-plugin-tests Related to 'scaffold plugin-tests' command command:scaffold-theme-tests Related to 'scaffold theme-tests' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants