Skip to content

Remove 'wp-blocks' from style dependency#151

Merged
schlessera merged 1 commit intowp-cli:masterfrom
ajitbohra:patch-1
May 19, 2018
Merged

Remove 'wp-blocks' from style dependency#151
schlessera merged 1 commit intowp-cli:masterfrom
ajitbohra:patch-1

Conversation

@ajitbohra
Copy link
Copy Markdown
Contributor

@ajitbohra ajitbohra commented May 18, 2018

@gziolo
Copy link
Copy Markdown
Contributor

gziolo commented May 18, 2018

Thanks @ajitbohra for opening this PR 👍

@gziolo
Copy link
Copy Markdown
Contributor

gziolo commented May 18, 2018

I see that @youknowriad updated handbook to make styles dependent on wp-edit-blocks. I think this in the case when someone wants to override the styles coming from Core blocks. Whatever we decide we should make sure that Gutenberg handbook is updated with whatever we agree upon here.

@youknowriad
Copy link
Copy Markdown

Actually, what I did is removing the wp-blocks dependency. I don't think third party styles should depend on any Gutenberg styles unless they reuse components from editor or something else. I think by default it should be an empty array.

@ajitbohra
Copy link
Copy Markdown
Contributor Author

@gziolo So far have been adding wp-blocks as the dependency to blocks style. A few days back @youknowriad mentioned on PR/Slack it's not needed, have stopped adding it as a dependency. Blocks & plugins seem to work fine.

In most scenarios wp-blocks is not required as a dependency for block style or editor_style except case mentioned above.

Whatever we decide we should also get the same implemented in create-guten-block.

@schlessera schlessera merged commit fc55f31 into wp-cli:master May 19, 2018
@schlessera schlessera added the command:scaffold-block Related to 'scaffold block' command label May 19, 2018
@schlessera schlessera added this to the 1.1.4 milestone May 19, 2018
@gziolo
Copy link
Copy Markdown
Contributor

gziolo commented May 21, 2018

@schlessera, thanks for the quick review 💯

danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Remove 'wp-blocks' from style dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:scaffold-block Related to 'scaffold block' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants