Modify scaffold block to create index.js#142
Merged
schlessera merged 1 commit intowp-cli:masterfrom Apr 19, 2018
salcode:sf/block-index-js-138
Merged
Modify scaffold block to create index.js#142schlessera merged 1 commit intowp-cli:masterfrom salcode:sf/block-index-js-138
schlessera merged 1 commit intowp-cli:masterfrom
salcode:sf/block-index-js-138
Conversation
schlessera
approved these changes
Apr 19, 2018
Member
|
Thanks for the pull-request, @salcode ! |
Contributor
Author
|
Awesome, thank you! |
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Modify scaffold block to create index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify scaffold block to create index.js instead of block.js
This is recommended as a best practice by @zgordon
This optimization allows one to import a block in JavaScript with
import './demo/';
rather than
import './demo/block.js';
See #138