Skip to content

Add PHP 7.2 to CI templates#135

Merged
danielbachhuber merged 3 commits intowp-cli:masterfrom
stevegrunwell:feature/add-php72-to-testing-matrix
Apr 10, 2018
Merged

Add PHP 7.2 to CI templates#135
danielbachhuber merged 3 commits intowp-cli:masterfrom
stevegrunwell:feature/add-php72-to-testing-matrix

Conversation

@stevegrunwell
Copy link
Copy Markdown
Contributor

WordPress 4.9.5 bumped the recommended PHP version to 7.2, so themes and plugins should probably make a point of supporting them.

This PR adds PHP 7.2 to the testing matricies for all of the CI providers, using the same settings as we were using for PHP 7.1.

WordPress 4.9.5 bumped the recommended PHP version to 7.2, so themes and plugins should probably make a point of supporting them.

This commit adds PHP 7.2 to the testing matricies for all of the CI providers, using the same settings as we were using for PHP 7.1.
@stevegrunwell
Copy link
Copy Markdown
Contributor Author

Failing tests are due to PHP 5.3 running out of memory, which is addressed in #136.

@danielbachhuber danielbachhuber added command:scaffold-plugin-tests Related to 'scaffold plugin-tests' command command:scaffold-plugin Related to 'scaffold plugin' command command:scaffold-theme-tests Related to 'scaffold theme-tests' command labels Apr 10, 2018
@danielbachhuber danielbachhuber added this to the 1.1.3 milestone Apr 10, 2018
@danielbachhuber danielbachhuber merged commit 09769c6 into wp-cli:master Apr 10, 2018
@stevegrunwell stevegrunwell deleted the feature/add-php72-to-testing-matrix branch April 10, 2018 15:13
danielbachhuber added a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:scaffold-plugin Related to 'scaffold plugin' command command:scaffold-plugin-tests Related to 'scaffold plugin-tests' command command:scaffold-theme-tests Related to 'scaffold theme-tests' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants