Exclude tests/test-sample.php via the phpunit.xml.dist file#134
Merged
danielbachhuber merged 3 commits intowp-cli:masterfrom Apr 10, 2018
stevegrunwell:feature/skip-sample-test-in-phpunit-config
Merged
Exclude tests/test-sample.php via the phpunit.xml.dist file#134danielbachhuber merged 3 commits intowp-cli:masterfrom stevegrunwell:feature/skip-sample-test-in-phpunit-config
danielbachhuber merged 3 commits intowp-cli:masterfrom
stevegrunwell:feature/skip-sample-test-in-phpunit-config
Conversation
This commit adds ./tests/test-sample.php as an exclusion in the phpunit.xml.dist file, preventing it from executing by default when developers run PHPUnit. Keeping the sample file can be helpful for projects (for instance, if the project is using a custom base test case and/or namespaces), but constantly asserting that true is, in fact, true isn't helpful.
… a more complicated process than it seemed, so skip that for now (since the change is already reflected in the theme scaffold tests)
Contributor
Author
|
Failing tests are due to PHP 5.3 running out of memory, which is addressed in #136. |
danielbachhuber
added
command:scaffold
danielbachhuber
approved these changes
Apr 10, 2018
danielbachhuber
added a commit
that referenced
this pull request
Nov 18, 2022
…n-phpunit-config Exclude tests/test-sample.php via the phpunit.xml.dist file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds ./tests/test-sample.php as an exclusion in the phpunit.xml.dist file, preventing it from executing by default when developers run PHPUnit.
Keeping the sample file can be helpful for projects (for instance, if the project is using a custom base test case and/or namespaces), but constantly asserting that true is, in fact, true isn't helpful.