Fix sed -i option on MacOS#132
Merged
schlessera merged 1 commit intowp-cli:masterfrom Mar 27, 2018
patrik-csak:fix-script
Merged
Fix sed -i option on MacOS#132schlessera merged 1 commit intowp-cli:masterfrom patrik-csak:fix-script
schlessera merged 1 commit intowp-cli:masterfrom
patrik-csak:fix-script
Conversation
The -i syntax is: `-i[SUFFIX]`. There should be no space between `-i` and the suffix. See https://www.gnu.org/software/sed/manual/sed.html#Command_002dLine-Options-1
Contributor
Author
|
Oops. Looks like maybe this broke other things. I'll investigate further. |
Contributor
|
@ptrkcsk that's not you that broke that, it's due to this recent change in core trunk https://core.trac.wordpress.org/ticket/43228 which hopefully will be addressed soon (if not we'll have to do a workaround). (See also wp-cli/wp-cli#4718 (comment)) Thanks for the PR by the way! Not a Mac user, but it's odd to me that this issue has only been noticed now?! |
Contributor
Author
Developing without virtualization is so 2008. 🙂 |
schlessera
approved these changes
Mar 27, 2018
Member
|
Thanks for the pull request, @ptrkcsk ! |
Contributor
Author
|
Glad I could help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -i syntax is:
-i[SUFFIX]. There should be no space between-iand the suffix. See sed Command Line Options.
Before this fix, I saw the following error on macOS: