Skip to content

fix wpcs in plugin generation#120

Merged
gitlost merged 2 commits intowp-cli:masterfrom
thrijith:GH-109-plugin
Jan 27, 2018
Merged

fix wpcs in plugin generation#120
gitlost merged 2 commits intowp-cli:masterfrom
thrijith:GH-109-plugin

Conversation

@thrijith
Copy link
Copy Markdown
Member

update code to remove WPCS warnings in plugin generated files #109

@gitlost
Copy link
Copy Markdown
Contributor

gitlost commented Jan 27, 2018

Thanks very much for this PR and #121 @thrijith. I'm going to remove #109 from the 1.1.2 milestone as incomplete at this late stage, so will be reviewing soon after WP-CLI 1.5.0 releases....

@gitlost gitlost added the command:scaffold-plugin Related to 'scaffold plugin' command label Jan 27, 2018
Copy link
Copy Markdown
Contributor

@gitlost gitlost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @thrijith changed my mind about merging this for 1.5.0 after my bitbucket tests failed phpcs!

Am wondering about the changes for the tests directory, were you getting phpcs errors without these?

@gitlost gitlost added this to the 1.1.2 milestone Jan 27, 2018
@gitlost gitlost merged commit d834c67 into wp-cli:master Jan 27, 2018
@gitlost
Copy link
Copy Markdown
Contributor

gitlost commented Jan 27, 2018

@thrijith in a bit of a rush (read panic) so took the liberty of removing the tests directory changes. Will revisit after 1.5.0, ta v much for the PR!

danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
fix wpcs in plugin generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:scaffold-plugin Related to 'scaffold plugin' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants