Skip to content

Tests: Improve Windows compatibility#81

Merged
swissspidy merged 2 commits intomainfrom
try/os
Mar 28, 2026
Merged

Tests: Improve Windows compatibility#81
swissspidy merged 2 commits intomainfrom
try/os

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@github-actions github-actions bot added help-wanted Extra attention is needed scope:testing Related to testing labels Mar 27, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the features/rewrite.feature file to skip two test scenarios on Windows environments using the @skip-windows tag. The review feedback suggests adding explanatory comments and TODO notes for these skips to improve maintainability and provide context for future developers regarding why these tests are currently disabled on Windows.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 2.0.18 milestone Mar 28, 2026
@swissspidy swissspidy marked this pull request as ready for review March 28, 2026 15:22
@swissspidy swissspidy requested a review from a team as a code owner March 28, 2026 15:22
Copilot AI review requested due to automatic review settings March 28, 2026 15:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Behat feature suite for the rewrite command to avoid known Windows-specific assertion failures by skipping affected scenarios.

Changes:

  • Add @skip-windows tag to the “Change site permastructs” scenario.
  • Add @skip-windows tag to the “Match as expected when full URL is provided” scenario.
  • Document (via comments) why the scenarios are skipped and note a TODO to investigate the root cause.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@swissspidy swissspidy merged commit d473ebf into main Mar 28, 2026
64 checks passed
@swissspidy swissspidy deleted the try/os branch March 28, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help-wanted Extra attention is needed scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants