Skip to content

Fix unit tests #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 8 commits into from
May 22, 2024
Merged

Fix unit tests #172

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f9ecb7
Rename class files
swissspidy May 22, 2024
011d727
Remove Travis config
swissspidy May 22, 2024
4aa8c54
Bump PHP requirement
swissspidy May 22, 2024
891d6ed
Add back `use` statements
swissspidy May 22, 2024
3ffb098
Make data providers static
swissspidy May 22, 2024
3a5cdd1
Fix `expectWarning` usage
swissspidy May 22, 2024
6507ba2
Undo some changes
swissspidy May 22, 2024
8a56070
Use `strtolower`
swissspidy May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix expectWarning usage
  • Loading branch information
@swissspidy
swissspidy committed May 22, 2024
commit 3a5cdd13d75ba094e5c35091e72d6334c0cbbbf3
12 changes: 10 additions & 2 deletions tests/Test_Arguments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,13 @@ public function set_up()
'flags' => $this->flags,
'options' => $this->options
);

set_error_handler(
static function ( $errno, $errstr ) {
throw new \Exception( $errstr, $errno );
},
E_ALL
);
}

/**
Expand All @@ -101,6 +108,7 @@ public function tear_down()
$this->options = null;
$this->settings = null;
self::clearArgv();
restore_error_handler();
}

/**
Expand Down Expand Up @@ -258,8 +266,8 @@ public function testParseWithValidOptions($cliParams, $expectedValues)
*/
public function testParseWithMissingOptions($cliParams, $expectedValues)
{
$this->expectWarning();
$this->expectWarningMessage('no value given for --option1');
$this->expectException(\Exception::class);
$this->expectExceptionMessage('no value given for --option1');
$this->_testParse($cliParams, $expectedValues);
}

Expand Down