PHP 8.2: strwidth() & Colors::pad()/decolorize() should always work with a string#163
Merged
danielbachhuber merged 3 commits intowp-cli:masterfrom Sep 29, 2023
Merged
PHP 8.2: strwidth() & Colors::pad()/decolorize() should always work with a string#163danielbachhuber merged 3 commits intowp-cli:masterfrom
danielbachhuber merged 3 commits intowp-cli:masterfrom
Conversation
slaFFik
changed the title
slaFFik
changed the title
slaFFik
changed the title
Member
|
Only had a quick glance, but can‘t we fix the calling code instead? |
Contributor
Author
|
I think we can, but it's like a dozen places all over the place :) So I do believe these methods should be adjusted (perhaps together with the calling code as well). |
danielbachhuber
approved these changes
Sep 29, 2023
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks @slaFFik !
I think this is fine to add. A lot of this code is already pretty dodgy, so casting to string isn't really hurting the code quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #162