Fix potential endless loop in prompt()#129
Merged
schlessera merged 2 commits intowp-cli:masterfrom Apr 10, 2018
Merged
Conversation
Member
|
Hi @zipofar, Thanks for the pull request. Could you include a test for this change too? |
8 tasks
Member
|
I tried adding tests to the Here's what I had so far: <?php
use cli\Streams;
/**
* Class TestStreams
*/
class TestStreams extends PHPUnit_Framework_TestCase {
/** @var resource */
protected $in;
/** @var resource */
protected $out;
/**
* Redirects STDIN/STDOUT to in-memory stream.
*/
public function setUp() {
foreach ( array( 'in', 'out' ) as $stream ) {
$this->$stream = fopen( 'php://memory', 'wb+' );
Streams::setStream( $stream, $this->$stream );
}
}
public function testPrompt() {
fwrite( $this->in, 'test' . PHP_EOL );
$result = Streams::prompt( 'Question' );
$this->assertEquals( 'test', $result );
}
}@danielbachhuber Do you have another idea on how to test this properly? |
Member
Nope. If it proves too difficult and we feel confident in the change, I think it can land without tests. |
schlessera
approved these changes
Apr 10, 2018
Member
|
Thanks for the PR, @zipofar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If user must enter zero, he can't exit from cycle.