Assume default package name if composer.json file cannot be retrieved#78
Merged
schlessera merged 4 commits intowp-cli:masterfrom Apr 19, 2018
Merged
Assume default package name if composer.json file cannot be retrieved#78schlessera merged 4 commits intowp-cli:masterfrom
schlessera merged 4 commits intowp-cli:masterfrom
Conversation
phlbnks
commented
Apr 13, 2018
phlbnks
commented
- Warning, not Error, when composer.json cannot be retrieved
- Return best-guess $package_name
- Warning not Error when composer.json cannot be retreived - Return best-guess $package_name
Author
|
Realised I've broken other tests. Fixing. |
added 2 commits
April 13, 2018 14:30
- requires PHP >= 5.4
Author
|
Previous test failed due to OOM error, but I realised that array dereferencing isn't supported in 5.3 anyway so I've updated to remove that. |
Author
|
OOM again ¯_(ツ)_/¯ |
Member
|
@emirpprime The OOM should now be fixed if you merge latest |
schlessera
added
bug
command:package-install
danielbachhuber
approved these changes
Apr 14, 2018
Member
|
I've merged master. |
Member
|
Thanks for the pull request, @emirpprime ! |
schlessera
changed the title
schlessera
added a commit
that referenced
this pull request
Jan 5, 2022
Handle unavailable composer.json on private repo Fixes #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.