Revert "Add regression test to detect Composer plugin errors" #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
approved these changes
Jan 5, 2018
Member
schlessera
left a comment
schlessera
left a comment
There was a problem hiding this comment.
Yes, I agree. The test was meant to uncover a problem with Phar generation, but never uses the actually generation process.
schlessera
added a commit
that referenced
this pull request
Jan 5, 2022
…-plugin-files Revert "Add regression test to detect Composer plugin errors"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #45
I think this should be reverted as it doesn't really test anything and fails if for instance phpunit is added to
require-dev(which could be something reasonable to do).Edit: actually ignore the point about failing as the other
Pharsteps would fail anyway, unlessmake-phar.phpwere updated to stripmyclab(used by phpunit 6). But this test should still be removed I think.