Controlled exception on find_latest_package (Github Driver)#60
Controlled exception on find_latest_package (Github Driver)#60gitlost merged 3 commits intowp-cli:masterfrom
Conversation
gitlost
left a comment
gitlost
left a comment
There was a problem hiding this comment.
Thanks for the PR @playmono , apologies for the delay in reviewing. This is definitely better behaviour than what's there now. Was wondering are you ever prompted for your ssh password when doing a package list while not using GITHUB_TOKEN and/or ~/.composer/auth.json?
src/Package_Command.php
Outdated
| $update_version = $latest->getPrettyVersion(); | ||
| } | ||
| } catch (Exception $e) { | ||
| $update = $update_version = 'Error whith Github Driver'; |
There was a problem hiding this comment.
It'd be better I think to just use a simple "error" message in the table and warn giving the full exception message eg
$update = $update_version = 'error';
WP_CLI::warning( $e->getMessage() );
There was a problem hiding this comment.
Yes, I remember being prompted for my ssh password but I don't remember in which case, sorry.
There was a problem hiding this comment.
Okay ta, I think to get around possible issues like that a new --non-interactive option should be added which I'll do in a separate issue/PR. For now I'm just going push my suggested change to your PR and commit if that's alright...
|
Sigh keep getting either "packagist.org" as here now or "getcomposer.org" (wp-cli/entity-command#122 (comment)) connection timeouts on Travis lately... restarting job... |
Controlled exception on find_latest_package (Github Driver)
3 participants
No description provided.