Conversation
thelovekesh
approved these changes
May 22, 2024
Member
thelovekesh
left a comment
thelovekesh
left a comment
There was a problem hiding this comment.
Some nitpicks. Rest LGTM!
Comment on lines
+12
to
+13
| .phpunit.cache | ||
| .phpunit.result.cache |
Member
There was a problem hiding this comment.
Suggested change
| .phpunit.cache | |
| .phpunit.result.cache | |
| *.[Cc]ache |
Member
Author
There was a problem hiding this comment.
I personally prefer the more verbose format
| beStrictAboutTestsThatDoNotTestAnything="true" | ||
| beStrictAboutTodoAnnotatedTests="true" | ||
| colors="true" | ||
| verbose="true"> |
Member
There was a problem hiding this comment.
We might want to remove it from here, as PHPUnit doesn't support it in future releases. Verbosity can be handled from CLI instead if required?
| beStrictAboutTodoAnnotatedTests="true" | ||
| colors="true" | ||
| verbose="true"> | ||
| <testsuite name="wp-cli/package-command tests"> |
Member
There was a problem hiding this comment.
Suggested change
| <testsuite name="wp-cli/package-command tests"> | |
| <testsuite name="default"> |
It can remain default given this test file is specific to this package. Also, I think we should add defaultTestSuite="default" attribute in the <phpunit> element?
Member
Author
There was a problem hiding this comment.
This is more consistent with other commands though. Main thing is that the name is defined, which it previously wasn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compatibility with latest PHPUnit on PHP 8.1+ after wp-cli/wp-cli-tests#206