Repository navigation
Support for Composer 2.5 #172
Description
We should update wp-cli/package-command so it can be installed where composer/composer 2.5 is a dependency.
From #167 (comment)
Done is:
wp-cli/package-commandsupportscomposer/composer:~2.5.
Activity
stefanfisk commentedon Feb 20, 2023
@danielbachhuber do you know anything specific that needs fixing, or is it just untested?
danielbachhuber commentedon Feb 20, 2023
@stefanfisk I think some fixes are needed for this: https://github.com/wp-cli/package-command/actions/runs/4189588371/jobs/7262087460#step:13:318
stefanfisk commentedon Feb 20, 2023
@danielbachhuber cool, that looks easy enough. Is it OK to go with only
^2.5.4, or is^1.10.23still needed as well?danielbachhuber commentedon Feb 20, 2023
@stefanfisk We can remove
^1.10.23as long as there aren't any backwards-compat issues.stefanfisk commentedon Feb 20, 2023
@danielbachhuber so after making the changes required I found some old related issues where this exact change was abandoned because Composer 2.3 is not compatible with PHP 5.6: #151 #152
So as long as PHP 5.6 compatibility is required this is not fixable. I'm not familiar with the PHP compatibility policy for WP-CLI, is PHP 5.6 compatiblity still required? And if it is, is there any end date for said compatiblity requirement? 5.6 is absolutely ancient by now :/
danielbachhuber commentedon Feb 20, 2023
@stefanfisk Ah, good find.
We'll need to support support PHP 5.6 at least as long as WordPress core supports 5.6. Fortunately, that should be over soon.
In 2019, our plan was to support PHP 5.6 for at least a year after core removed support. It seems like we may need to revisit that, though.
stefanfisk commentedon Mar 1, 2023
As a workaround, I switch from
wp-cli-bundleto requiring the individual packages except forpackage-command.It's a bit ugly, but would you be OK with having to implementations of
ComposerIO, one with types and one without, and then have ComposerIO.php require the correct one based onPHP_MAJOR_VERSION?danielbachhuber commentedon Mar 1, 2023
@stefanfisk Yes, that would be a perfectly fine approach
Fixes #327: Update to PHP 8.2
Fixes #327: Update to PHP 8.2
Fixes #327: Update to PHP 8.2