Skip to content

Reinstate ghostscript/imagick install; fix bmp name in regenerate test.#69

Merged
schlessera merged 4 commits intomasterfrom
reinstate-imagick-gs-install
Feb 25, 2018
Merged

Reinstate ghostscript/imagick install; fix bmp name in regenerate test.#69
schlessera merged 4 commits intomasterfrom
reinstate-imagick-gs-install

Conversation

@gitlost
Copy link
Copy Markdown
Contributor

@gitlost gitlost commented Feb 18, 2018

See #44 and #61

Reinstates ghostscript/imagick install which got overwritten by #44. This means that a number of tests weren't getting run for months 😢

Fixes BMP filename added in #61

Also adds travis-before_install-append.yml which will be used by PR to scaffold-package-command to allow for package-specific stuff to be added to .travis.yml.

@gitlost gitlost added scope:testing Related to testing command:media-regenerate Related to 'media regenerate' command labels Feb 18, 2018
@gitlost gitlost added this to the 1.1.5 milestone Feb 18, 2018
This was referenced Feb 19, 2018
@schlessera
Copy link
Copy Markdown
Member

Also adds travis-before_install-append.yml which will be used by PR to scaffold-package-command to allow for package-specific stuff to be added to .travis.yml.

Waiting for that matching PR before merging this one.

@gitlost
Copy link
Copy Markdown
Contributor Author

gitlost commented Feb 22, 2018

The 81a803b commit moves the remove_old_images() function into needs_regeneration(), and splits the $image_sizes check in two so that thumbnails don't get destroyed if an image is skipped.

This non-destructiveness should also really extend to the no metadata case, but haven't come up with a nice way to do this, so leaving for the moment.

Also added some tests of this behaviour, and added some extra comments.

The 8f7bc79 commit reinstates the caching of the ImageMagick build, adding another Travis append file.

I'll do the PR on scaffold-package-command for adding the extra Travis stuff very shortly...

@schlessera schlessera merged commit 3923852 into master Feb 25, 2018
@schlessera schlessera deleted the reinstate-imagick-gs-install branch May 9, 2018 19:06
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Reinstate ghostscript/imagick install; fix bmp name in regenerate test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:media-regenerate Related to 'media regenerate' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants