Evaluate $upgrading numeric value when checking if maintenance mode is active#22
Evaluate $upgrading numeric value when checking if maintenance mode is active#22danielbachhuber merged 12 commits intowp-cli:mainfrom
$upgrading numeric value when checking if maintenance mode is active#22Conversation
…hecking if the site is in maintenance mode or not.
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
I'd suggest we proceed forward on this path: #22 (comment)
We'll want to make sure we have a few different scenarios covering each of the potential .maintenance file formats.
|
Hey guys, Thanks for the feedback; I thought to give it another try by adding the warning when the value is a non-numeric one. Also, I've changed the regex to account for when space might be missing between the |
|
@selul It's looking great! Just a few small things to fix up, and then this should be good to land. You'll want to make sure all of the tests are passing too. |
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
|
Thanks for the feedback @danielbachhuber 🚀 ! I've applied the changes. |
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Looks pretty solid! Just two small tweaks remaining on my end. I'd love to get another @wp-cli/committers review, though.
danielbachhuber
added
command:maintenance-mode
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
|
Thanks for the feedback, @danielbachhuber! I've made the changes! |
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for your work on this, @selul !
danielbachhuber
changed the title
$upgrading numeric value when checking if maintenance mode is active
4 participants
Attempt to fix #19 by checking the upgrading value when seeing if the site is in maintenance mode or not. Re-use the logic that core uses -> https://github.com/WordPress/WordPress/blob/master/wp-includes/load.php#L310-L314