Warn if no plugin or theme has been specified#38
Merged
schlessera merged 2 commits intomasterfrom Aug 2, 2018
Merged
Conversation
schlessera
requested changes
Aug 2, 2018
features/language-theme.feature
Outdated
| When I run `wp language theme list --all` | ||
| Then STDOUT should be: | ||
| """ | ||
| Success: No theme installed. |
Member
There was a problem hiding this comment.
Broken test: the string should be Success: No themes installed. (plural)
Member
Author
There was a problem hiding this comment.
D'oh!
I didn't notice this because locally I get this error:
Given an empty {THEME_DIR} directory # features/steps/given.php:14
Attempted to delete directory '/private/var/folders/c1/8bn4rqzx0h1f49bxgmrzk2hm0000gn/T/wp-cli-test-run-language-theme.feature.158-5b63048a63f427.56141581/wp-content/themes' that is not in the temp directory '/var/folders/c1/8bn4rqzx0h1f49bxgmrzk2hm0000gn/T'. features/steps/given.php:20
(notice /private/var vs /var)
That's why I thought the issue is with removing the files, not with the success message.
Member
There was a problem hiding this comment.
I need to figure something out with this /private prefix on Macs. I have this issue from time to time too.
This was referenced Aug 2, 2018
schlessera
added
command:language-plugin-list
schlessera
approved these changes
Aug 2, 2018
schlessera
added a commit
that referenced
this pull request
Jan 5, 2022
Warn if no plugin or theme has been specified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow using
wp theme pathand then deleting that directory doesn't work... It seems to work in https://github.com/wp-cli/extension-command/pull/83/files though.Fixes #27.