Support wp language theme uninstall --all#124
Merged
swissspidy merged 1 commit intowp-cli:mainfrom Oct 18, 2023
Merged
Conversation
Contributor
Author
|
Install example: Uninstall example: then on a second run |
swissspidy
reviewed
Aug 24, 2023
atoomic
force-pushed
the
uninstall-all
branch
2 times, most recently
from
a238b8c to
e912cf8
Compare
Contributor
Author
|
note: need to adjust and add some unit tests |
Contributor
Author
|
fixed phpcs |
atoomic
force-pushed
the
uninstall-all
branch
3 times, most recently
from
78c1026 to
4c67fa2
Compare
1 task
Refs: wp-cli#122 Add support for '--all' to the Theme uninstall function. Switch the report output to use a table and support for json.
Contributor
Author
|
fixed and added some tests, ready for review round 2 |
swissspidy
approved these changes
Aug 29, 2023
Member
swissspidy
left a comment
swissspidy
left a comment
There was a problem hiding this comment.
Really nice work, thank you!
Would you also be open to add the same for plugins next? :-)
swissspidy
changed the title
wp language theme uninstall --all
danielbachhuber
requested changes
Aug 29, 2023
| twentyseventeen,de_DE,"not installed" | ||
| twentysixteen,de_DE,"not installed" | ||
| """ | ||
| And STDERR should be empty |
Member
There was a problem hiding this comment.
Can we add a scenario for neither <theme> nor --all is provided?
| \WP_CLI::set_logger( $logger ); | ||
| } | ||
|
|
||
| /* process all themes */ |
Member
There was a problem hiding this comment.
This comment is extraneous and can be removed.
danielbachhuber
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #122
Add support for '--all' to the Theme
uninstall function.
Switch the report output to use a table
and support for json.
Related wp-cli/wp-cli#5832