Fixed inaccurate make-mo command arguments docs.#438
Fixed inaccurate make-mo command arguments docs.#438sun wants to merge 3 commits intowp-cli:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
sun
changed the title
sun
changed the title
|
Thanks for opening this. Not sure about the suggested changes 🤔
It sounds like you're trying to run the command from a different directory where that file doesn't exist, in which case of course it will fail. And then, yes, |
|
Closing as per the above |
|
That is not what the documentation suggests. Specifically, to run the command inside of the directory already. I understand you want to keep the queue clean by closing this, but it’s a bit too quick and premature. |
|
I‘m happy to accept a docs change with a better example, but the current suggested change js just wrong and doesn‘t match the description. |
2 participants
Follow-up to
make-mo: Add option to specify filename #372make-mo: Add destination file support #373Problem
The documentation on https://developer.wordpress.org/cli/commands/i18n/make-mo/ and in the help is inaccurate and misleading. It states:
But the suggested command yields an error:
The correct command argument is to just specify the file including path:
Proposed solution
Correct the documentation.