Skip to content

Add @when before_wp_load to command namespace#42

Merged
swissspidy merged 1 commit intomasterfrom
before-wp-load
Jul 10, 2018
Merged

Add @when before_wp_load to command namespace#42
swissspidy merged 1 commit intomasterfrom
before-wp-load

Conversation

@swissspidy
Copy link
Copy Markdown
Member

@swissspidy swissspidy commented Jul 10, 2018

Before this PR:

$ wp i18n
Error: Error establishing a database connection. This either means that the username and password information in your `wp-config.php` file is incorrect or we can’t contact the database server at `localhost`. This could mean your host’s database server is down.

With this PR:

$ wp i18n
usage: wp i18n make-pot <source> [<destination>] [--slug=<slug>] [--domain=<domain>] [--merge[=<file>]] [--exclude=<paths>] [--skip-js]

See 'wp help i18n <command>' for more information on a specific command.

Fixes #40.

@swissspidy swissspidy requested a review from a team July 10, 2018 10:58
@schlessera schlessera added the command:i18n Related to 'i18n' command label Jul 10, 2018
@schlessera schlessera added this to the 0.1.0 milestone Jul 10, 2018
@swissspidy
Copy link
Copy Markdown
Member Author

swissspidy commented Jul 10, 2018

@schlessera No worries. To prevent accidental commits to master we could always protect the branch in the repository settings.

@swissspidy swissspidy merged commit e8cc5ef into master Jul 10, 2018
@swissspidy swissspidy deleted the before-wp-load branch July 10, 2018 11:10
@schlessera
Copy link
Copy Markdown
Member

schlessera commented Jul 10, 2018

The master branch is already protected. I was just delusional, that must be it.

schlessera pushed a commit that referenced this pull request Jan 6, 2022
@swissspidy
Merge pull request #42 from wp-cli/before-wp-load
be68604 
Add `@when before_wp_load` to command namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

command:i18n Related to 'i18n' command

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@swissspidy @schlessera